fix: incorrect outstanding on non-pos invoice with write_off_account #43316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
added
backport version-14-hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
write_off_accountis auto set based on the POS Profile when user marks the Invoice as POS - 'Is Pos' checbox.When
write_off_accountis set, invoice's Outstanding Amount is not updated. But, if you set and unset 'Is Pos' checkbox,write_off_accountis still set, due to which the Outstanding Amount field is not updated even though it is a normal invoice.This is more pronounced in Sales Return (Credit Note), as the outstanding amount is not even updated in draft status due to which it always shows '0', even if 'Update Outstanding for Self' is enabled.
Fix
If Invoice is not POS, write_off_account will be unset by default.